Resolve build-tooling wrinkles and remove stale Tests-with-s directory#10
Merged
Conversation
- Build-Plugin.ps1 now reads ID and Version from plugin.json instead of hard-coding them. The previous copy-paste from Flow.JiraSearch had left the wrong GUID in the script and a stale 1.0.1 version string in the ZIP filename. - Start.ps1 derives the plugin folder name from plugin.json (Name + Version) when -PluginFolderName is not provided, so newly bumped versions land in the right %APPDATA%\FlowLauncher\Plugins\ folder. - Remove Flow.ConfluenceSearch.Tests/ (with an s); it was never in the solution and only contained an empty Search/ResultContextTests.cs. - Broaden .gitignore from .claude/settings.local.json to the whole .claude/ directory (with an exception for settings.json), so other per-machine Claude Code state files (locks, scheduled tasks) stop showing up as untracked. - Drop the resolved wrinkles from CLAUDE.md and docs/DEVELOPMENT.md. No version bump: nothing user-facing changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tooling-only cleanup, no version bump and no behaviour change for users.
Build-Plugin.ps1now readsIDandVersionfromplugin.jsoninstead of hard-coding them. The previous copy-paste from Flow.JiraSearch had left the wrong GUID in the script and a stale1.0.1version string in the ZIP filename.Start.ps1derives the plugin folder name fromplugin.json(Name+Version) when-PluginFolderNameis not provided, so newly bumped versions land in the right%APPDATA%\FlowLauncher\Plugins\folder.Flow.ConfluenceSearch.Tests/(with ans); it was never in the solution and only contained an emptySearch/ResultContextTests.cs..gitignorefrom.claude/settings.local.jsonto the whole.claude/directory (with an exception forsettings.json), so other per-machine Claude Code state files (locks, scheduled tasks) stop showing up as untracked.CLAUDE.mdanddocs/DEVELOPMENT.md.Test plan
dotnet build Flow.ConfluenceSearch.sln -c Debug— clean.dotnet run --project Flow.ConfluenceSearch.Test --no-build— 43/43 pass.Build-Plugin.ps1producesFlow.ConfluenceSearch-v1.1.0.zip(matchingplugin.json:Version) andStart.ps1writes intoConfluence Search-1.1.0/.